Fixes #1483 - problems with selection when triple clicking#1489
Open
ianchadwick wants to merge 1 commit intoalohaeditor:howling-madfrom
ianchadwick:patch-3
Open
Fixes #1483 - problems with selection when triple clicking#1489ianchadwick wants to merge 1 commit intoalohaeditor:howling-madfrom ianchadwick:patch-3
ianchadwick wants to merge 1 commit intoalohaeditor:howling-madfrom
ianchadwick:patch-3
Conversation
Not sure what else uses expandToBlock or what the reasoning behind the next() call around the boundary was so this one definitely needs a bit of thought when reviewing. This change does appear to fix both problems outlined in the issue without any visible side affects.
Contributor
|
Can one of the admins verify this patch? |
2 similar comments
Contributor
|
Can one of the admins verify this patch? |
Contributor
|
Can one of the admins verify this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure what else uses expandToBlock or what the reasoning behind the next() call around the boundary was so this one definitely needs a bit of thought when reviewing. This change does appear to fix both problems outlined in the issue without any visible side affects.