Update port-helper-attribute-field.js#1141
Open
cecilialam wants to merge 1 commit intoalohaeditor:devfrom
Open
Update port-helper-attribute-field.js#1141cecilialam wants to merge 1 commit intoalohaeditor:devfrom
cecilialam wants to merge 1 commit intoalohaeditor:devfrom
Conversation
Contributor
|
test |
cecilialam
added a commit
to cecilialam/Aloha-Editor
that referenced
this pull request
Mar 24, 2014
This is related to Update port-helper-attribute-field.js alohaeditor#1141. I am adding a placeholder message to the Table Summary textbox on the toolbar.
Contributor
|
test this please |
Contributor
|
✘ Test failed. |
Contributor
|
The repository timeout test failed. This might be a glitch. I'll rerun the tests. |
Contributor
|
test this please |
Contributor
|
✔ Test passed. |
Contributor
|
Can one of the admins verify this patch? |
1 similar comment
Contributor
|
Can one of the admins verify this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the placeholder attribute in the AttributeField class. This is for adding the Placeholder to the table summary text field in the Aloha toolbar.