Skip to content

Word Content Handler Bugfixes#1079

Open
ggalileo wants to merge 3 commits intoalohaeditor:devfrom
ggalileo:ctct-word-content-handler
Open

Word Content Handler Bugfixes#1079
ggalileo wants to merge 3 commits intoalohaeditor:devfrom
ggalileo:ctct-word-content-handler

Conversation

@ggalileo
Copy link
Contributor

@ggalileo ggalileo commented Feb 6, 2014

This pull request fixes two issues in the Word Content Handler

  • Replace Word specific <o:p/> tags with
    tags to maintain line breaks
  • Unwrap paragraph tags so that the visual double space does not appear

This code has been tested across browsers by our QE.

  1. obey coding guidelines
  2. write JSLint compliant code
  3. write JSDoc for every method you touched during your implementation
  4. write a human-readable :) Changelog entry that describes your change
  5. add a qunit test (if it makes sense) and/or document the steps to manually test it (in a separate guides page)
  6. test your changes in Internet Explorer 7, 8, 9 and the latest Firefox and latest Chrome
  7. document your changes in a guides page
  8. include this list in a your pull request

@Jotschi
Copy link
Contributor

Jotschi commented Feb 7, 2014

Code looks good. Please see my other comment about changes to the code and reformatting the code.

@ggalileo
Copy link
Contributor Author

Thanks for reviewing, I removed the reformatting change.

@GenticsDev
Copy link
Contributor

Can one of the admins verify this patch?

@Jotschi
Copy link
Contributor

Jotschi commented Feb 19, 2014

Admin please build this request

@GenticsDev
Copy link
Contributor

Test PASSed.
Refer to this link for build results: http://jenkins.office:8080/job/alohaeditor-upstream-pullrequests/18/

@GenticsDev
Copy link
Contributor

Can one of the admins verify this patch?

1 similar comment
@GenticsDev
Copy link
Contributor

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants