fix(i18n): add the missing German setup gate strings - #493
Merged
Conversation
German was missing "Running setup...", "Setup failed." and "Continue to Agent", so the setup gate fell back to English. All five locales now carry the same 248 keys. Also drops "Rebuild", which was only present in German and is referenced nowhere in the app. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HzGnpFC9q8ydDPD8ygabKv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
German was missing three keys, so the setup gate rendered in English for German
users:
Running setup...Setup failed.Continue to AgentThese are the strings shown while a project's setup script runs and when it
fails, which is exactly the path that just changed in 0.1.78, so it is a bad one
to leave half translated.
Changes
Added the three strings:
Also removed
"Rebuild" = "Neu bauen";, which existed only in German and isreferenced nowhere in
Sources/orResources/.Verification
Audited keys across all five locales. Before: German had 3 missing and 1 orphan.
After, every locale matches English exactly at 248 keys:
plutil -lintpasses on all five files.Not built locally: the ghostty submodule is not checked out in the worktree I was
working from, and building it takes about 15 minutes. This change touches only
.stringscontent with no source references added or removed, and the releasebuild will exercise it.
Note, not changed here
All five locales define
"GitHub" = "GitHub";twice, at lines 82 and 206, onceper section. Identical values, so no functional effect. Left alone rather than
touching five files for cosmetics.