Skip to content

fix(ci): keep appcast history when a previous release has no assets #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidpoblador merged 1 commit into from
Jul 30, 2026
Merged

fix(ci): keep appcast history when a previous release has no assets #492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,12 +257,20 @@ jobs:
exit 1
fi

# Download existing appcast from previous release to merge with (preserves items
# for the Homebrew update popover). Cannot use --latest because release-please
# already created the current (empty) release.
PREV_TAG=$(gh release list --repo "$GITHUB_REPOSITORY" --limit 10 --json tagName --jq "[.[] | select(.tagName != \"$TAG_NAME\")][0].tagName")
if [ -n "$PREV_TAG" ]; then
gh release download "$PREV_TAG" --repo "$GITHUB_REPOSITORY" --pattern "appcast.xml" --output existing-appcast.xml || true
# Download an existing appcast to merge with (preserves items for the Homebrew
# update popover). Cannot use --latest because release-please already created
# the current (empty) release. Walk back through previous releases until one
# actually yields an appcast: a release whose build failed carries no assets,
# and stopping at it would silently drop every historical item.
for CANDIDATE in $(gh release list --repo "$GITHUB_REPOSITORY" --limit 10 --json tagName --jq "[.[] | select(.tagName != \"$TAG_NAME\")][].tagName"); do
rm -f existing-appcast.xml
if gh release download "$CANDIDATE" --repo "$GITHUB_REPOSITORY" --pattern "appcast.xml" --output existing-appcast.xml 2>/dev/null; then
echo "Carrying forward appcast items from $CANDIDATE"
break
fi
done
if [ ! -f existing-appcast.xml ]; then
echo "::warning::No previous appcast found; this release's appcast will contain only its own item"
fi

DMG_URL="https://github.com/alltuner/factoryfloor/releases/download/v${VERSION}/${DMG_NAME}"
Expand Down