fix(evm): preflight Amsterdam call runtime OOG before inspection - #284
Closed
0xalpharush wants to merge 1 commit into
Closed
fix(evm): preflight Amsterdam call runtime OOG before inspection#2840xalpharush wants to merge 1 commit into
0xalpharush wants to merge 1 commit into
Conversation
rakita
reviewed
Jul 15, 2026
| } | ||
|
|
||
| let checkpoint = self.state.checkpoint(); | ||
| let (regular, state) = self.eip2780_call_charges(message); |
Contributor
There was a problem hiding this comment.
Yeah this is not correct, and needs changing. eip2780_call_charges needs to take into account gas limit. and checkpoint creation is in wrong place. If eip2780 checks fail eip7702 delegations need reverting.
Contributor
|
Will close this if this is okay, it looks like it is in the wrong place. I need to implement glam-devnet-7 for evm2, so it will be solved then |
Contributor
Author
|
fine to close. lmk when evm2 amsterdam is up-to-date with revm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preflight Amsterdam depth-zero CALL runtime gas before emitting
Inspector::callor transfer-log callbacks.Impact
A value transfer that could afford intrinsic gas but not Amsterdam new-account state gas previously appeared as a failed call frame with an EIP-7708 log callback. The journal was rolled back, but tracer consumers observed a frame and log that never entered execution.
Testing
amsterdam_runtime_oog_call_value_is_not_inspectedstructured_compare_amsterdam/crash-dc81cee312825a7f24931cb945e94e42b780b134replays cleanly