refactor: introduce BalEvm - #357
Open
klkvr wants to merge 3 commits into
Open
Conversation
mattsse
approved these changes
May 11, 2026
klkvr
force-pushed
the
klkvr/bal-db-internally
branch
from
May 21, 2026 10:19
93a9ff4 to
cc45f5b
Compare
klkvr
force-pushed
the
klkvr/bal-db-internally
branch
from
May 22, 2026 11:10
cc45f5b to
5cd9393
Compare
mattsse
approved these changes
May 22, 2026
|
|
||
| if let Some(provided_bal) = &self.ctx.block_access_list { | ||
| if bal.as_ref() != Some(provided_bal.as_ref()) { | ||
| return Err(BlockValidationError::msg("invalid BAL provided").into()); |
Member
There was a problem hiding this comment.
should we make this a dedicated error?
klkvr
force-pushed
the
klkvr/bal-db-internally
branch
from
May 22, 2026 14:13
f8ba82e to
743650a
Compare
mattsse
approved these changes
May 22, 2026
Comment on lines
+195
to
+198
| /// Returns this EVM as a mutable BAL-capable EVM, if supported. | ||
| fn as_bal_evm_mut(&mut self) -> Option<&mut dyn BalEvm> { | ||
| None | ||
| } |
Member
There was a problem hiding this comment.
I like this approach, this should be sufficient enough, and usually we only ever have one implementation of this, if this fails to support bals at runtime this would then always indicate an implemantation issue, imo it's fine to enfrce this at runtime
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
introduces
BalEvmwhich allowsEthBlockExecutorto drive BAL building/verification internally, and adds BAL toBlockExecutionResult