fix: CreateHouse silently fails when ai2thor build changes#64
Open
sandesh-8622 wants to merge 1 commit intoallenai:mainfrom
Open
fix: CreateHouse silently fails when ai2thor build changes#64sandesh-8622 wants to merge 1 commit intoallenai:mainfrom
sandesh-8622 wants to merge 1 commit intoallenai:mainfrom
Conversation
…enai#47 allenai#53 allenai#60 turns out branch=main in constants.py makes it download whatever the latest ai2thor build is every time you run it. when that build changes the house JSON format breaks but the error just says Unable to CreateHouse which tells you nothing about what actually went wrong changed the assert to actually print the real error from ai2thor so at least people can see what is happening closes allenai#47 allenai#53 allenai#60
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking into why so many people are hitting "Unable to CreateHouse!" in #47 #53 #60 and I think I found what's causing it.
In constants.py, PROCTHOR_INITIALIZATION uses branch="main" which means every time someone runs the code it downloads whatever the latest ai2thor unity build is at that moment. The problem is when that build changes the house JSON format breaks but the only error you get is:
which tells you absolutely nothing about what actually went wrong.
You can see the real error in issue #53 where the C# traceback shows:
"Error converting value WoodSlashhatch to type MaterialProperties"
that's the actual ai2thor error that was being hidden.
What I changed:
message from ai2thor so users can see what failed
Note: I couldn't run the full pipeline since that needs a GPU which my computer did not support but the
imports work fine. Maintainers should confirm the right commit_id to pin in constants.py once they verify which build works with schema 1.0.0.