adds simple smoke tests#76
Open
warmbowski wants to merge 4 commits into
Open
Conversation
88eda73 to
4ea4ed0
Compare
warmbowski
commented
Mar 19, 2026
| extracted_answer: Any = None | ||
| metadata: dict[str, Any] = field(default_factory=dict) | ||
| tool_calls: list[ToolCall] | None = None | ||
| provider_extras: dict[str, Any] = field(default_factory=dict) |
Contributor
Author
There was a problem hiding this comment.
this is a dict set up for provider specific (in this case litellm) properties from the response. Only thing add in this is has_reasoning. I suppose other providers could also implement this on LMOutput (i.e. embedded thinking tag). Mainly, I am wondering if this is okay to add this dict (can rename, maybe can just be in metadata, but that looks like its for metric calls).
undfined
reviewed
Mar 30, 2026
|
|
||
|
|
||
| @dataclass(frozen=True, slots=True) | ||
| class SubstringScorer(Scorer): |
Collaborator
There was a problem hiding this comment.
Look fro existing implementation of this, I think we have something.
332a01a to
e922f33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds some simple smoke tests for running against deployed models on the litellm provider. These are mostly recreate some sanity check logic from this script that Pradeep runs against deployed olmo3 models on deployment: https://github.com/allenai/open-instruct/blob/pd-olmo-api-eval/scripts/evaluate_api_endpoints.py#L125
closes https://github.com/allenai/playground-issues-repo/issues/965
Type of Change
Testing
pytest tests/ --ignore=tests/integration/)Checklist