Skip to content

Proof of concept for MagicLookup#187

Draft
soldni wants to merge 1 commit into
mainfrom
soldni/magic
Draft

Proof of concept for MagicLookup#187
soldni wants to merge 1 commit into
mainfrom
soldni/magic

Conversation

@soldni

@soldni soldni commented Jan 5, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Tested with magic_v2.py (1000 iterations, done 500 times to get std); it's about a 7% performance hit, which feels ok:

$ python scripts/magic_v2.py 
try_new: 7.94e-03 +/- 4.70e-04 s
try_old: 7.36e-03 +/- 3.82e-04 s

@soldni soldni requested a review from kyleclo January 5, 2023 05:27
@soldni soldni marked this pull request as draft January 5, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kyleclo kyleclo Awaiting requested review from kyleclo

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@soldni