Minor fixes for OrderedBehavior#17
Open
bfncs wants to merge 2 commits intoalkemann:masterfrom
bfncs:fixes
Open
Minor fixes for OrderedBehavior#17bfncs wants to merge 2 commits intoalkemann:masterfrom bfncs:fixes
bfncs wants to merge 2 commits intoalkemann:masterfrom
bfncs:fixes
Conversation
This is an attempt to remerge my patched version of this file with the upstream. Changes include but are not necessarily limited to: * Fixed strict PHP warnings, in particular by removing issues with call-time pass-by-reference to keep compatibility with PHP >=5.3. See: http://php.net/manual/en/language.references.pass.php * Converted everything to PSR-1/2 compatible coding style. See: http://www.php-fig.org/psr/psr-1/ & http://www.php-fig.org/psr/psr-2/ * Minor edits of typos and the like in comments and PHPDoc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there and thanks for your still really useful
OrderedBehavior!I have been keeping a marginally changed private fork of your behavior for some years now, manually merging in the patches of the few last minor versions. After going through it again today, I just thought I could at least ask for an upstream remerge.
The hassle is that I switched style to PSR-1/2 long ago, so there's a lot of whitespace related changes here (at least Github provides a diff that ignores whitespace changes) and you probably don't like the style conventions. Apart from this, there are some minor but hopefully useful changes inside:
Please just let me know, whether you can merge it as it is or if you would merge particular pieces under other circumstances.