Simplify pickup of system protobuf #892
Conversation
|
@davidrohr @ktf this is what I have in mind, I am currently testing it with O2. For FairRoot, I have already tested it and it correctly picks:
This works with a patched FairRoot only. Bump to patch version will be added to this PR later. Stay tuned! |
|
See FairRootGroup/FairRoot#652, proposed for upstream dev. |
* Use a single variable pointing to the root installation * Do not pass the variable if protobuf comes from the system * Bump FairRoot to a version compatible with our fix
dberzano
force-pushed
the
fix-system-protobuf
branch
from
c2183b1 to
e6bc9f6
Compare
dberzano
changed the title
|
So if you pick up this alidist version (and you don't have FairRoot in devel mode, so that you are forced to use our version) it should work. Waiting for confirmation from @davidrohr :-) |
|
@dberzano : Hi Dario, I rebuilt from scratch and protobuf is picked up correctly from the system. |
|
@davidrohr thanks for checking, I had to merge it before your check as @shahor02 needed it sooner :-) |
|
@dberzano : I saw that, but wanted to let you know that it works with system protobuf as well, so I think we can close this topic now. |
|
@dberzano this (or something related to this) seems to have broken the PR builds on system which have both system and our protobuf, e.g. the build machines. See for example: |
|
@dberzano @dennisklein for the record the actual problem seems to be: which if I understand correctly is simply wrong. |
|
Yes, looks wrong. It seems to mix up system installation with custom installation somehow. I had a holiday today, will have a look at it tomorrow. |
|
I have a fix. I'm making a PR. |
4 participants
Should supersede #879.