fix template_string wrong MSVC workaround#1177
Merged
Merged
Conversation
Replace the old logic that stripped any first-word that wasn't const/volatile (which would incorrectly strip "unsigned", "long", etc.) with a targeted list of MSVC elaborated type specifiers. The prefix strings include a trailing space to avoid matching type names that happen to start with a keyword.
|
for detail, goto summary download Artifacts |
|
for detail, goto summary download Artifacts |
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
qicosmos/iguana#344 去掉了template_string的MSVC的前缀，当时没发现，对
long doubleunsigned int这类的直接通过找空格来裁剪是有问题的，改成了显式的判断前缀。注意对
long long来说还是有问题的：enumenum classenum struct的输出则都是·enum前缀