[struct_pack] fix c++17 add std::array to continuous_container to match C++20 behavior#1164
Merged
poor-circle merged 1 commit intoApr 3, 2026
Conversation
|
|
…ch C++20 behavior
songqing
force-pushed
the
fix/continuous-container-std-array
branch
from
cb0f408 to
2e5f1ad
Compare
|
for detail, goto summary download Artifacts |
|
for detail, goto summary download Artifacts |
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Issue: The C++17 version only hard-codes recognition of std::vector and std::basic_string, while std::array (which has a contiguous memory layout) is completely ignored. In C++20, using std::span{container} correctly recognizes all contiguous containers. This causes std::array<TrivialType, N> to miss the fast bulk memory copy path in C++17 mode, leading to worse serialization performance and behavior that is inconsistent with the C++20 version.
What is changing
Example