Skip to content

[struct_pack] fix c++17 enable_if missing ::type and wrong std::string_view type in user_defined_serialization_imp #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
poor-circle merged 1 commit into from
Apr 3, 2026
Merged

[struct_pack] fix c++17 enable_if missing ::type and wrong std::string_view type in user_defined_serialization_imp #1163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions include/ylt/struct_pack/reflection.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,8 +694,8 @@ struct memory_reader;
template <typename T>
struct user_defined_serialization_impl<T, std::void_t<
decltype(sp_serialize_to(std::declval<struct_pack::detail::memory_writer&>(),std::declval<const T&>())),
std::enable_if<std::is_same_v<decltype(sp_deserialize_to(std::declval<struct_pack::detail::memory_reader&>(),std::declval<T&>())), struct_pack::err_code>,
std::enable_if<std::is_same_v<decltype(sp_get_needed_size(std::declval<const T&>())), std::string_view>>>>>
std::enable_if_t<std::is_same_v<decltype(sp_deserialize_to(std::declval<struct_pack::detail::memory_reader&>(),std::declval<T&>())), struct_pack::err_code>>,
std::enable_if_t<std::is_same_v<decltype(sp_get_needed_size(std::declval<const T&>())), std::size_t>>>>
: std::true_type {};

template <typename Type>
Expand All @@ -706,7 +706,7 @@ struct memory_reader;

template <typename T>
struct user_defined_type_name_impl<T, std::void_t<
std::enable_if<std::is_same_v<decltype(sp_set_type_name((T*)nullptr)), std::string_view>>>>
std::enable_if_t<std::is_same_v<decltype(sp_set_type_name((T*)nullptr)), std::string_view>>>>
: std::true_type {};

template <typename Type>
Expand Down
Loading