fix(cmake): patch Arrow for CMAKE_POLICY_VERSION_MINIMUM#184
Merged
lxy-9602 merged 2 commits intoalibaba:mainfrom Mar 18, 2026
Merged
fix(cmake): patch Arrow for CMAKE_POLICY_VERSION_MINIMUM#184lxy-9602 merged 2 commits intoalibaba:mainfrom
lxy-9602 merged 2 commits intoalibaba:mainfrom
Conversation
The existing EP_COMMON_CMAKE_ARGS fix (alibaba#175) covers direct dependencies, but Arrow internally builds its own sub-dependencies (e.g., brotli) via ExternalProject_Add. These sub-dependencies specify cmake_minimum_required(VERSION 2.8), which causes a fatal error on CMake >= 3.30. Patch Arrow's ThirdpartyToolchain.cmake to append -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to EP_COMMON_CMAKE_ARGS when CMake >= 3.30, ensuring all bundled sub-dependencies are configured successfully. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
It is tested on CMake 4.2.3. |
There was a problem hiding this comment.
Pull request overview
This PR updates the local Arrow patch set to ensure Arrow’s own ExternalProject_Add sub-dependencies (e.g., brotli) configure successfully under CMake 3.30+, by propagating CMAKE_POLICY_VERSION_MINIMUM into Arrow’s internal EP_COMMON_CMAKE_ARGS.
Changes:
- Patch Arrow’s
cpp/cmake_modules/ThirdpartyToolchain.cmaketo append-DCMAKE_POLICY_VERSION_MINIMUM=3.5whenCMAKE_VERSION >= 3.30.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing
EP_COMMON_CMAKE_ARGSfix (#175) covers direct dependencies, but Arrow internally builds its own sub-dependencies (e.g., brotli) via ExternalProject_Add. These sub-dependencies specify cmake_minimum_required(VERSION 2.8), which causes a fatal error on CMake >= 3.30.Patch Arrow's ThirdpartyToolchain.cmake to append
-DCMAKE_POLICY_VERSION_MINIMUM=3.5toEP_COMMON_CMAKE_ARGSwhen CMake >= 3.30, ensuring all bundled sub-dependencies are configured successfully.