-
Notifications
You must be signed in to change notification settings - Fork 2.5k
fix(controller): index disabled dropdown options so the full list is visible #648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| import { beforeEach, describe, expect, it } from 'vitest' | ||
|
|
||
| import domTree from './index.js' | ||
|
|
||
| function setupSizes() { | ||
| Object.defineProperty(HTMLElement.prototype, 'offsetWidth', { | ||
| configurable: true, | ||
| get() { | ||
| return 100 | ||
| }, | ||
| }) | ||
| Object.defineProperty(HTMLElement.prototype, 'offsetHeight', { | ||
| configurable: true, | ||
| get() { | ||
| return 30 | ||
| }, | ||
| }) | ||
| } | ||
|
|
||
| function buildDropdown(html: string) { | ||
| return domTree({ | ||
| doHighlightElements: false, | ||
| viewportExpansion: -1, | ||
| interactiveBlacklist: [], | ||
| interactiveWhitelist: [], | ||
| }) as any | ||
| } | ||
|
|
||
| function getIndexedOptions(tree: any) { | ||
| return Object.values(tree.map) | ||
| .filter((n: any) => n.tagName === 'li' && typeof n.highlightIndex === 'number') | ||
| .sort((a: any, b: any) => a.highlightIndex - b.highlightIndex) | ||
| } | ||
|
|
||
| describe('dropdown option indexing (#519)', () => { | ||
| beforeEach(() => { | ||
| setupSizes() | ||
| document.body.innerHTML = '' | ||
| }) | ||
|
|
||
| it('indexes enabled dropdown options', () => { | ||
| document.body.innerHTML = ` | ||
| <div class="el-select-dropdown"> | ||
| <ul class="el-select-dropdown__list"> | ||
| <li class="el-select-dropdown__item" style="cursor:pointer">选项1</li> | ||
| <li class="el-select-dropdown__item" style="cursor:pointer">选项2</li> | ||
| <li class="el-select-dropdown__item" style="cursor:pointer">选项3</li> | ||
| </ul> | ||
| </div> | ||
| ` | ||
| const tree = buildDropdown(document.body.innerHTML) | ||
| const indexed = getIndexedOptions(tree) | ||
| expect(indexed.length).toBe(3) | ||
| }) | ||
|
|
||
| it('indexes disabled dropdown options so the full list is visible to the LLM', () => { | ||
| document.body.innerHTML = ` | ||
| <div class="el-select-dropdown"> | ||
| <ul class="el-select-dropdown__list"> | ||
| <li class="el-select-dropdown__item" style="cursor:pointer">闸片产线</li> | ||
| <li class="el-select-dropdown__item is-disabled" style="cursor:not-allowed">落料车间</li> | ||
| <li class="el-select-dropdown__item" style="cursor:pointer">机加车间</li> | ||
| </ul> | ||
| </div> | ||
| ` | ||
| const tree = buildDropdown(document.body.innerHTML) | ||
| const indexed = getIndexedOptions(tree) | ||
| expect(indexed.length).toBe(3) | ||
| }) | ||
|
|
||
| it('still excludes disabled buttons outside dropdowns', () => { | ||
| document.body.innerHTML = ` | ||
| <button style="cursor:not-allowed" disabled>保存</button> | ||
| ` | ||
| const tree = buildDropdown(document.body.innerHTML) | ||
| const buttons = Object.values(tree.map).filter((n: any) => n.tagName === 'button') | ||
| expect(buttons.every((n: any) => n.highlightIndex === undefined)).toBe(true) | ||
| }) | ||
| }) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -687,6 +687,39 @@ export default ( | |
| ) | ||
| } | ||
|
|
||
| /** | ||
| * @edit dropdown/menu option detection | ||
| * li/option elements (or role=option/menuitem/listitem) inside a dropdown or menu | ||
| * container are treated as indexable even when visually disabled (cursor: not-allowed), | ||
| * so the LLM sees the complete option list. | ||
| */ | ||
| const DROPDOWN_OPTION_ROLES = new Set([ | ||
| 'option', | ||
| 'menuitem', | ||
| 'menuitemradio', | ||
| 'menuitemcheckbox', | ||
| 'listitem', | ||
| ]) | ||
| const DROPDOWN_CONTAINER_SELECTOR = [ | ||
| '[role="listbox"]', | ||
| '[role="menu"]', | ||
| '[role="menubar"]', | ||
| 'select', | ||
| '.el-select-dropdown', | ||
| '.el-dropdown-menu', | ||
| '[data-toggle="dropdown"]', | ||
| ].join(', ') | ||
|
|
||
| function isDropdownOptionElement(element) { | ||
| if (!element || element.nodeType !== Node.ELEMENT_NODE) return false | ||
| const tagName = element.tagName.toLowerCase() | ||
| const role = element.getAttribute('role') | ||
| if (tagName !== 'li' && tagName !== 'option' && !(role && DROPDOWN_OPTION_ROLES.has(role))) { | ||
| return false | ||
| } | ||
| return Boolean(element.closest(DROPDOWN_CONTAINER_SELECTOR)) | ||
| } | ||
|
|
||
| /** | ||
| * Checks if an element is interactive. | ||
| * | ||
|
|
@@ -711,6 +744,15 @@ export default ( | |
| return true // Skip whitelisted elements | ||
| } | ||
|
|
||
| /** | ||
| * @edit dropdown options should stay indexable even when disabled, | ||
| * otherwise the LLM cannot see or select the full option list | ||
| * (e.g. Element UI / Avue selects with disabled options). | ||
| */ | ||
| if (isDropdownOptionElement(element)) { | ||
| return true | ||
|
Comment on lines
+752
to
+753
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When a dropdown item is disabled only by CSS/class, such as the Element UI case added in the new test with AGENTS.md reference: AGENTS.md:L150-L151 Useful? React with 👍 / 👎.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
| } | ||
|
|
||
| // Cache the tagName and style lookups | ||
| const tagName = element.tagName.toLowerCase() | ||
| const style = getCachedComputedStyle(element) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a
role="menu"/role="listbox"uses the common ARIA pattern of<li role="none">wrappers around realrole="menuitem"children, this condition still treats the wrapperlias an option because everyliinside a dropdown container returns true before the normal role/cursor/disabled checks run. That gives both the non-actionable wrapper and the actual menu item numeric indexes, so the agent can choose an empty/no-op wrapper index and the simplified DOM is polluted with duplicate actions; consider excluding explicit non-option roles such asnone/presentation/separatoror only accepting barelis for known dropdown item classes.Useful? React with 👍 / 👎.