Skip to content

feat(i18n): add Arabic language support - #638

Open
ahmed5bdelaal wants to merge 1 commit into
alibaba:mainfrom
ahmed5bdelaal:feat/add-arabic-language
Open

feat(i18n): add Arabic language support#638
ahmed5bdelaal wants to merge 1 commit into
alibaba:mainfrom
ahmed5bdelaal:feat/add-arabic-language

Conversation

@ahmed5bdelaal

Copy link
Copy Markdown

Summary

This PR adds Arabic (ar) language support.

Changes

  • Added Arabic locale.
  • Registered Arabic as a supported language.
  • Translated all UI strings.
  • No breaking changes.

Thank you for reviewing!

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 78b9f6c477

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".


export default defineConfig({
test: {
environment: 'jsdom',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the missing jsdom dependency for UI tests

In a clean checkout, the new @page-agent/ui test script is picked up by root npm test/CI, and this config asks Vitest to start the jsdom environment; Vitest documents that this environment uses the jsdom package (docs), but the repo only declares happy-dom and vitest, not jsdom, so the UI test workspace will fail before running any tests. Add jsdom to the repo devDependencies/lockfile or use the already-installed happy-dom/default node environment instead.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants