fix(page-controller): calculate visible clip rect for isTopElement to fix dropdown indexing (#519) - #591
Open
DakshLohchab wants to merge 1 commit into
Open
fix(page-controller): calculate visible clip rect for isTopElement to fix dropdown indexing (#519)#591DakshLohchab wants to merge 1 commit into
DakshLohchab wants to merge 1 commit into
Conversation
… fix dropdown indexing (alibaba#519)
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR fixes a bug where
elementFromPoint()fails to identify dropdown options that are clipped by anoverflow: auto/hiddencontainer, specifically impacting Element UI / Avue dropdowns appended to the body.I added a
getVisibleClipRecthelper that intersects the element's rect with its clipping ancestors. This ensures the sample points forisTopElementactually land inside the rendered region, correctly indexing all visible options.Closes #519
Type
Requirements / 要求