fix: guard exponent parsing against end-of-input in readNumber0 - #7832
Open
waterWang wants to merge 1 commit into
Open
fix: guard exponent parsing against end-of-input in readNumber0#7832waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
For input like "1e", "1e-" or "1e+" (and uppercase variants), the number reader consumed bytes past the end of the buffer, throwing ArrayIndexOutOfBoundsException instead of JSONException. Guard the three reads that follow an exponent marker and reject an exponent with no following digits. Fixes alibaba#7807
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
JSON.parseon a document that ends inside a number's exponent —"1e","1e-","1e+"and their uppercase variants — threwArrayIndexOutOfBoundsExceptioninstead ofJSONException.In
JSONReaderUTF8.readNumber0andJSONReaderUTF16.readNumber0, the three reads that follow an exponent marker (e/E) consumed bytes without an end-of-input guard:When the buffer ended right at the marker, this read past the end and threw
AIOOBE. Additionally, an exponent with no following digits ("1e") was accepted silently.The fix
offset == end ? EOI : bytes[offset++].JSONException(consistent with how a trailing1.is already rejected).Verification
JSON.parse("1e"),"1E","1e-","1e+","1.0e","-1e"etc. all now throwJSONException."1e5"→100000.0,"1e-2"→0.01,"1e0"→1.Issue7807test;164number/JSONReader tests pass,0failures.Fixes #7807