fix: handle null operands in LogicOrOperator for consistency with && and ! - #460
Open
chenjunwenhao wants to merge 1 commit into
Open
fix: handle null operands in LogicOrOperator for consistency with && and !#460chenjunwenhao wants to merge 1 commit into
chenjunwenhao wants to merge 1 commit into
Conversation
…and ! LogicAndOperator and LogicNotOperator both treat null as false, but LogicOrOperator throws INVALID_BINARY_OPERAND when either operand is null. This makes `null || true` fail at runtime while `null && true` correctly returns false. Add null-to-false conversion to align the behavior across all three logical operators.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LogicAndOperatorandLogicNotOperatorboth treatnullasfalse, butLogicOrOperatorthrowsINVALID_BINARY_OPERANDwhen either operand isnull. This inconsistency causesnull || trueto fail at runtime whilenull && truecorrectly returnsfalseand!nullcorrectly returnstrue.Problem
Fix
Add null-to-false conversion in
LogicOrOperator.execute(), matching the pattern already used inLogicAndOperatorandLogicNotOperator:Tests
Added
logic_or_null.qltest suite covering:||operator with null operands (left, right, both)orkeyword with null operands!nullbehaviorChanged Files
src/main/java/.../runtime/operator/logic/LogicOrOperator.java— added null handlingsrc/test/resources/testsuite/independent/operator/logic_or_null.ql— new test suite