CI: add GHA build+test multi-platform workflow#17
Merged
Merged
Conversation
jannotti
approved these changes
Jun 17, 2026
jannotti
left a comment
There was a problem hiding this comment.
Something like this is very important for key derivation, to show that we get the same keys derived from the same seed on different platforms.
We probably don't have tests for that, because it has not been important before. But when we want to derive from 24 words, we need to show we get the same keys everywhere. We should have no problem, because we're emulating floating point.
Contributor
Author
We'll have to add a big-endian target some day! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs C and Go tests on 5 platforms: Linux (x86, arm); Mac (x86, Apple Silicon); Windows.
Upgrades to Go 1.24 which fixes Windows cgo build error on the GHA runner, and also provides a builtin
crypto/sha3used infalcon_test.go(so now this library has no Go package dependencies)