Skip to content

CI: add GHA build+test multi-platform workflow#17

Merged
cce merged 2 commits into
mainfrom
cce/add-ci
Jun 17, 2026
Merged

CI: add GHA build+test multi-platform workflow#17
cce merged 2 commits into
mainfrom
cce/add-ci

Conversation

@cce

@cce cce commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Runs C and Go tests on 5 platforms: Linux (x86, arm); Mac (x86, Apple Silicon); Windows.

Upgrades to Go 1.24 which fixes Windows cgo build error on the GHA runner, and also provides a builtin crypto/sha3 used in falcon_test.go (so now this library has no Go package dependencies)

@cce cce requested review from algorandskiy, jannotti and nullun June 17, 2026 15:09

@jannotti jannotti left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like this is very important for key derivation, to show that we get the same keys derived from the same seed on different platforms.

We probably don't have tests for that, because it has not been important before. But when we want to derive from 24 words, we need to show we get the same keys everywhere. We should have no problem, because we're emulating floating point.

@cce

cce commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

Something like this is very important for key derivation, to show that we get the same keys derived from the same seed on different platforms.

We'll have to add a big-endian target some day!

@cce cce merged commit 1f71e3a into main Jun 17, 2026
6 checks passed
@cce cce deleted the cce/add-ci branch June 17, 2026 15:44

@nullun nullun left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you for adding this.

Comment thread .github/workflows/test.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants