fixed callbackOrDummy to play with null#66
Open
arunoda wants to merge 2 commits intoalexscheelmeyer:masterfrom
Open
fixed callbackOrDummy to play with null#66arunoda wants to merge 2 commits intoalexscheelmeyer:masterfrom
arunoda wants to merge 2 commits intoalexscheelmeyer:masterfrom
Conversation
Owner
|
Can you specify which circumstances cause callbackOrDummy to be called with null? Generally I would think that is an error on the callers part and something that I would actually want to catch, not ignore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometime
callbackOrDummycalled with anullthen it breaks tests.This will fix it.