Skip to content

goserbench: Switch to math/rand/v2 for rng #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

goserbench: Switch to math/rand/v2 for rng #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46f7bd4
goserbench: Switch to math/rand/v2 for rng
matheusd Jul 21, 2025
97bf948
report: Re-generate report with new data
matheusd Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions goserbench/goserbench.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ package goserbench
import (
"fmt"
"math"
"math/rand"
"math/rand/v2"
"testing"
"time"
)
Expand All @@ -18,24 +18,24 @@ const (
MaxSmallStructPhoneSize = 10
)

func randString(l int) string {
func randString(rng *rand.Rand, l int) string {
buf := make([]byte, l)
for i := 0; i < (l+1)/2; i++ {
buf[i] = byte(rand.Intn(256))
buf[i] = byte(rng.IntN(256))
}
return fmt.Sprintf("%x", buf)[:l]
}

func generateSmallStruct() []*SmallStruct {
func generateSmallStruct(rng *rand.Rand) []*SmallStruct {
a := make([]*SmallStruct, 0, 1000)
for i := 0; i < 1000; i++ {
a = append(a, &SmallStruct{
Name: randString(MaxSmallStructNameSize),
Name: randString(rng, MaxSmallStructNameSize),
BirthDay: time.Now(),
Phone: randString(MaxSmallStructPhoneSize),
Siblings: rand.Intn(5),
Spouse: rand.Intn(2) == 1,
Money: rand.Float64(),
Phone: randString(rng, MaxSmallStructPhoneSize),
Siblings: rng.IntN(5),
Spouse: rng.IntN(2) == 1,
Money: rng.Float64(),
})
}
return a
Expand All @@ -44,13 +44,14 @@ func generateSmallStruct() []*SmallStruct {
// BenchMarshalSmallStruct benchmarks marshalling the [SmallStruct] type.
func BenchMarshalSmallStruct(b *testing.B, s Serializer) {
b.Helper()
data := generateSmallStruct()
rng := rand.New(rand.NewPCG(0xdeadbeef, 0x1701d))
data := generateSmallStruct(rng)

b.ReportAllocs()
b.ResetTimer()
var serialSize int
for i := 0; i < b.N; i++ {
o := data[rand.Intn(len(data))]
o := data[rng.IntN(len(data))]
bytes, err := s.Marshal(o)
if err != nil {
b.Fatalf("marshal error %s for %#v", err, o)
Expand All @@ -65,6 +66,7 @@ func BenchMarshalSmallStruct(b *testing.B, s Serializer) {
// against the source struct.
func BenchUnmarshalSmallStruct(b *testing.B, s Serializer, validate bool) {
b.Helper()
rng := rand.New(rand.NewPCG(0xdeadbeef, 0x1701d))

var timePrecision time.Duration
if stp, ok := s.(SerializerTimePrecision); ok {
Expand All @@ -75,7 +77,7 @@ func BenchUnmarshalSmallStruct(b *testing.B, s Serializer, validate bool) {
forcesUTC = set.ForcesUTC()
}

data := generateSmallStruct()
data := generateSmallStruct(rng)
ser := make([][]byte, len(data))
var serialSize int
for i, d := range data {
Expand Down Expand Up @@ -115,7 +117,7 @@ func BenchUnmarshalSmallStruct(b *testing.B, s Serializer, validate bool) {
b.ResetTimer()

for i := 0; i < b.N; i++ {
n := rand.Intn(len(ser))
n := rng.IntN(len(ser))
*o = SmallStruct{}
err := s.Unmarshal(ser[n], o)
if err != nil {
Expand Down
Loading
Loading