fix(lambda): pin external installs from lockfiles - #858
Draft
jperezrealini wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm cifor reproducible Linux/architecture-specific bundlesbun.lockbfiles and validate Bun workspace importersWhy
Lambda external package installation previously pinned only direct dependencies. npm could therefore re-resolve transitive packages, producing bundles that differed from the source lockfile. Some Bun workspace, alias, and binary-lockfile cases could also select the wrong package or depend on an existing
node_modulestree.Impact
External Lambda packages now install reproducibly from the reachable lockfile dependency graph, including native Linux/arm64 packages, aliases, and nested version conflicts.
Validation
bun run test test/Bundle/InstalledPackages.test.ts --retry 0(35 tests: 33 passed, 2 gated integrations skipped)bun tsc -bbun oxlint packages/alchemy/src/Bundle/InstalledPackages.ts packages/alchemy/test/Bundle/InstalledPackages.test.tsbun oxfmt --writeon changed filesgit diff --check