Skip to content

Change pa-page-title so no 'title' attribute is used #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ki9us wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Change pa-page-title so no 'title' attribute is used #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bce9309
change `title` to `pageTitle`
keith24 Apr 23, 2016
73b1203
change `title` to `page-title`
keith24 Apr 23, 2016
7295fdc
Merge pull request #1 from keith24/patch-1
keith24 Apr 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/elements/common/pa-page-title.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
}
</style>

<h2>{{ title }}</h2>
<h2>{{ pageTitle }}</h2>
<span class="flex"></span>
<paper-icon-button icon="view-module" selected$="{{colsview}}" on-click="setColsView"></paper-icon-button>
<paper-icon-button icon="view-stream" selected$="{{!colsview}}" on-click="setStreamView"></paper-icon-button>
Expand All @@ -44,7 +44,7 @@ <h2>{{ title }}</h2>
is: 'pa-page-title',

properties: {
title: {
pageTitle: {
type: String,
value: 'Page Title'
},
Expand Down Expand Up @@ -87,4 +87,4 @@ <h2>{{ title }}</h2>
})();
</script>

</dom-module>
</dom-module>
22 changes: 11 additions & 11 deletions app/elements/common/pa-pages.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,52 +18,52 @@
<iron-pages attr-for-selected="data-route" selected="{{route}}">

<section data-route="dashboard">
<pa-page-title title="Dashboard" cols='{{cols}}'></pa-page-title>
<pa-page-title page-title="Dashboard" cols='{{cols}}'></pa-page-title>
<pa-dashboard cols='{{cols}}' todos="{{todos}}" user="{{user}}" on-sign-in="signIn"></pa-dashboard>
</section>

<section data-route="charts">
<pa-page-title title="Charts" cols='{{cols}}'></pa-page-title>
<pa-page-title page-title="Charts" cols='{{cols}}'></pa-page-title>
<pa-charts cols='{{cols}}'></pa-charts>
</section>

<section data-route="tables">
<pa-page-title title="Tables" cols='{{cols}}'></pa-page-title>
<pa-page-title page-title="Tables" cols='{{cols}}'></pa-page-title>
<pa-tables cols='{{cols}}'></pa-tables>
</section>

<section data-route="form-elements">
<pa-page-title title="Form Elements" cols='{{cols}}'></pa-page-title>
<pa-page-title page-title="Form Elements" cols='{{cols}}'></pa-page-title>
<pa-form-elements cols='{{cols}}'></pa-form-elements>
</section>

<section data-route="typo">
<pa-page-title title="Typography" cols='{{cols}}'></pa-page-title>
<pa-page-title page-title="Typography" cols='{{cols}}'></pa-page-title>
<pa-typo cols='{{cols}}'></pa-typo>
</section>

<section data-route="buttons">
<pa-page-title title="Buttons" cols='{{cols}}'></pa-page-title>
<pa-page-title page-title="Buttons" cols='{{cols}}'></pa-page-title>
<pa-buttons cols='{{cols}}'></pa-buttons>
</section>

<section data-route="ui-other">
<pa-page-title title="Other UI Elements" cols='{{cols}}'></pa-page-title>
<pa-page-title page-title="Other UI Elements" cols='{{cols}}'></pa-page-title>
<pa-ui-other cols='{{cols}}'></pa-ui-other>
</section>

<section data-route="maps">
<pa-page-title title="Maps" cols='{{cols}}'></pa-page-title>
<pa-page-title page-title="Maps" cols='{{cols}}'></pa-page-title>
<pa-maps cols='{{cols}}'></pa-maps>
</section>

<section data-route="user-profile">
<pa-page-title title="User Profile" cols='{{cols}}'></pa-page-title>
<pa-page-title page-title="User Profile" cols='{{cols}}'></pa-page-title>
<pa-profile cols='{{cols}}' profile="{{profile}}"></pa-profile>
</section>

<section data-route="not-found">
<pa-page-title title="Page Not Found"></pa-page-title>
<pa-page-title page-title="Page Not Found"></pa-page-title>
<pa-not-found></pa-not-found>
</section>

Expand All @@ -80,4 +80,4 @@
})();
</script>

</dom-module>
</dom-module>