ci: configure or remove Partytown and add dev scripts + minimal CI #899
Closed
xerion12 wants to merge 7 commits intoakash-network:mainfrom
Closed
ci: configure or remove Partytown and add dev scripts + minimal CI #899xerion12 wants to merge 7 commits intoakash-network:mainfrom
xerion12 wants to merge 7 commits intoakash-network:mainfrom
Conversation
|
The developer scripts you mentioned are not in the package.json |
Contributor
|
hii @xerion0712 , your formatting check would fail in most of the cases as prettier convention is not being followed by the contributors actively:
|
Author
|
thanks for calling this out. I’ve kept formatting visibility in CI but made it non-blocking so it won’t fail builds while still surfacing issues. I also added clear local scripts and can follow up with a pre commit hook to auto-format before commits if you prefer strict enforcement.”
|
Author
|
if you prefer stricter enforcement, i can add Husky + lint staged in a followup so formatting is auto applied before commits and we can make CI strict again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@astrojs/partytown: configure properly or remove unused.check,typecheck,format.