Skip to content

fix: increase HTTP request timeout from 10s to 30s#2635

Merged
baktun14 merged 1 commit intomainfrom
fix/timeout-query
Feb 11, 2026
Merged

fix: increase HTTP request timeout from 10s to 30s#2635
baktun14 merged 1 commit intomainfrom
fix/timeout-query

Conversation

@baktun14
Copy link
Contributor

@baktun14 baktun14 commented Jan 30, 2026

Summary by CodeRabbit

  • Improvements
    • Increased HTTP request timeout thresholds from 10 to 30 seconds for deployment and lease operations, reducing timeout errors and improving reliability on slower network connections.

✏️ Tip: You can customize this high-level summary in your review settings.

@baktun14 baktun14 requested a review from a team as a code owner January 30, 2026 23:22
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 30, 2026

📝 Walkthrough

Walkthrough

The pull request increases HTTP request timeouts from 10 seconds to 30 seconds across the HTTP SDK services. Two methods in DeploymentHttpService and one method in LeaseHttpService receive the timeout adjustments. No control flow, error handling, or API signatures are modified.

Changes

Cohort / File(s) Summary
HTTP Service Timeout Configuration
packages/http-sdk/src/deployment/deployment-http.service.ts, packages/http-sdk/src/lease/lease-http.service.ts
Increased timeout values from 10000 ms to 30000 ms across three HTTP request methods: DeploymentHttpService.findByOwnerAndDseq, DeploymentHttpService.findAll, and LeaseHttpService.list. No functional or structural changes to control flow or error handling.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • ygrishajev

Poem

🐰 Tick-tock, the timeouts grow,
From seconds ten to thirty's glow,
No logic bent, no flow rearranged,
Just patient waits—the values changed! ⏰✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: increasing HTTP request timeouts from 10s to 30s across multiple services in the HTTP SDK.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/timeout-query

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.90%. Comparing base (4665f2b) to head (0cd6308).
⚠️ Report is 62 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2635      +/-   ##
==========================================
- Coverage   50.91%   50.90%   -0.01%     
==========================================
  Files        1055     1055              
  Lines       29781    29781              
  Branches     6713     6701      -12     
==========================================
- Hits        15162    15160       -2     
+ Misses      14335    14212     -123     
- Partials      284      409     +125     
Flag Coverage Δ *Carryforward flag
api 78.25% <ø> (-0.03%) ⬇️
deploy-web 32.24% <ø> (ø)
log-collector 75.35% <ø> (ø)
notifications 87.94% <ø> (ø)
provider-console 81.48% <ø> (ø) Carriedforward from 4665f2b
provider-proxy 84.35% <ø> (ø) Carriedforward from 4665f2b
tx-signer 79.25% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.
see 40 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

await this.httpClient.get<DeploymentListResponse>("/akash/deployment/v1beta4/deployments/list", {
params,
timeout: 10000
timeout: 30000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: does it make sense to retry on timeout instead? waiting for 30s is a way too long

@baktun14 baktun14 merged commit a231221 into main Feb 11, 2026
75 checks passed
@baktun14 baktun14 deleted the fix/timeout-query branch February 11, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants