fix: increase HTTP request timeout from 10s to 30s#2635
Conversation
📝 WalkthroughWalkthroughThe pull request increases HTTP request timeouts from 10 seconds to 30 seconds across the HTTP SDK services. Two methods in DeploymentHttpService and one method in LeaseHttpService receive the timeout adjustments. No control flow, error handling, or API signatures are modified. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2635 +/- ##
==========================================
- Coverage 50.91% 50.90% -0.01%
==========================================
Files 1055 1055
Lines 29781 29781
Branches 6713 6701 -12
==========================================
- Hits 15162 15160 -2
+ Misses 14335 14212 -123
- Partials 284 409 +125
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
| await this.httpClient.get<DeploymentListResponse>("/akash/deployment/v1beta4/deployments/list", { | ||
| params, | ||
| timeout: 10000 | ||
| timeout: 30000 |
There was a problem hiding this comment.
question: does it make sense to retry on timeout instead? waiting for 30s is a way too long
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.