chore: change production configuration#101
Conversation
| { | ||
| "UsosOAuth": { | ||
| "CallbackUrl": "http://localhost/api/auth/callback" | ||
| "CallbackUrl": "https://put-wiki.joszkooo.work/api/auth/callback" |
There was a problem hiding this comment.
I think that we should grab the url from env, not hardcode it cause it can be changed later
There was a problem hiding this comment.
From my perspective we should use env files only for storing app secrets and appsettings files for public configuration and not mix it. I agree that putting CallbackUrl for prod app in appsettings.Production.json is not as good idea. Especially that change here will require server docker image to be built and released with next version.
I can remove this file entirely (but leave appsettings.json for all enviroments public config and appsettings.Development.json for local development) and put CallbackUrl and everything enviroment specific to compose.prod.yml (or compose.override.yml in case of dev env in docker compose), so that it won't require new server image release (but deploy in case of change is still necessary to reload compose file on production).
There was a problem hiding this comment.
And I will update docs (in separate PR) to explain how we manage configuration and which enviroments we use
| run: | | ||
| git checkout -f main | ||
| git pull origin main | ||
| git fetch origin main |
There was a problem hiding this comment.
| git fetch origin main | |
| git fetch -f origin main |
Changes
How to test (optional)
Steps for reviewer to verify changes.
Screenshots / recordings (for UI stuff)
...
Checklist
To have your PR reviewed put the link e.g.
https://github.com/akai-org/put-wiki/pull/0to theReview PRthread on put-wiki dc channel (you must be member of the AKAI discord server)