Skip to content

chore: change production configuration#101

Open
Aleks334 wants to merge 5 commits into
mainfrom
deployment-related-changes
Open

chore: change production configuration#101
Aleks334 wants to merge 5 commits into
mainfrom
deployment-related-changes

Conversation

@Aleks334

@Aleks334 Aleks334 commented Jun 26, 2026

Copy link
Copy Markdown
Member

Changes

  • docker container for maintenance page exposes port that matches app proxy port (so that app remains accessible when proxy is down)
  • remove unnecessary 443 port exposure for proxy on prod (cloudflare uses only 8080)
  • change CallbackUrl value for prod env to correct url
  • use git reset to update codebase on prod env (raspberry pi). This makes sure that anything changed on pi (like changes in work dir, commits, etc) that is not in github repo will be overwritten by origin (github).

How to test (optional)

Steps for reviewer to verify changes.

Screenshots / recordings (for UI stuff)

...

Checklist

  • PR is linked to an issue (tab on the right).
  • Acceptance criteria (from issue) are met.
  • All status checks (CI) are green.
  • Tests added / updated.
  • Docs updated (if applicable).

To have your PR reviewed put the link e.g. https://github.com/akai-org/put-wiki/pull/0 to the Review PR thread on put-wiki dc channel (you must be member of the AKAI discord server)

@github-actions

Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Complexity Health
Infrastructure 7% 7% 112
Application 68% 67% 23
Domain 56% 50% 11
Summary 16% (71 / 443) 16% (14 / 88) 146

@Aleks334 Aleks334 requested a review from Joszkooo June 26, 2026 20:04
{
"UsosOAuth": {
"CallbackUrl": "http://localhost/api/auth/callback"
"CallbackUrl": "https://put-wiki.joszkooo.work/api/auth/callback"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should grab the url from env, not hardcode it cause it can be changed later

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my perspective we should use env files only for storing app secrets and appsettings files for public configuration and not mix it. I agree that putting CallbackUrl for prod app in appsettings.Production.json is not as good idea. Especially that change here will require server docker image to be built and released with next version.

I can remove this file entirely (but leave appsettings.json for all enviroments public config and appsettings.Development.json for local development) and put CallbackUrl and everything enviroment specific to compose.prod.yml (or compose.override.yml in case of dev env in docker compose), so that it won't require new server image release (but deploy in case of change is still necessary to reload compose file on production).

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I will update docs (in separate PR) to explain how we manage configuration and which enviroments we use

run: |
git checkout -f main
git pull origin main
git fetch origin main

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
git fetch origin main
git fetch -f origin main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants