docs: production-readiness audit + usefulness doc (dogfooded), and a README demo fix#19
docs: production-readiness audit + usefulness doc (dogfooded), and a README demo fix#19ajaysurya1221 wants to merge 2 commits into
Conversation
…not behavior The "Try it in 30 seconds" demo claim — "handler() lives in app.py", backed by a C3 `symbol:` existence checker — was tagged `kind: "behavior"`. That is exactly the mismatch the project's own `--strength-gate=fail` refuses (a load-bearing behavior claim backed only by an existence check), so the flagship demo violated the gate dorian now ships and promotes. Retag it `reference` (the checker proves existence, not behavior). Behavior-preserving under the default gate (off); the recipe still seals on verify and revokes on drift. The black-box README test's mirrored copy is synced; its assertions check only the commands, not the kind, so all tests stay green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Two durable docs for new users and skeptical reviewers: - docs/PRODUCTION_READINESS_AUDIT.md — evidence-backed readiness review (944 tests green local + CI x3.11/3.12/3.13, zero-dep isolated wheel install, first-hand golden-path transcript, full security-boundary map, verdict + ranked punch list). - docs/DORIAN_USEFULNESS.md — why dorian matters, strength-labeled evidence, the trigger-vs-truth ceiling, copy-paste user journey, adoption fit. Dogfooded: docs/changes/production-readiness-audit.md is sealed under `--strength-gate=fail` (verified 7/7; 0 load-bearing high-risk) with its claims in production-readiness-audit.claims.json and the sealed sidecar committed, matching the existing docs/changes/ convention. Load-bearing facts: the two-axis implementation (binding gate = trigger, strength gate = truth) and the audit's invariants — Python >=3.11 and a zero-dependency core — pinned by config-value checkers. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
📝 WalkthroughWalkthroughThe PR changes the README example claim kind and matching test to ChangesProduction-readiness documentation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/PRODUCTION_READINESS_AUDIT.md (1)
87-87: 📐 Maintainability & Code Quality | 🔵 TrivialAdd language specifier to fenced code block.
The golden-path transcript code block is missing a language tag. Add
bashortextto satisfy MD040 and improve rendering.-``` +```bash🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/PRODUCTION_READINESS_AUDIT.md` at line 87, The golden-path transcript fenced block is missing a language specifier, so update the Markdown code fence in the production readiness audit doc to include a tag such as bash or text. Locate the fenced block in the transcript section and make the opening fence explicitly typed so it satisfies MD040 and renders correctly.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@docs/PRODUCTION_READINESS_AUDIT.md`:
- Line 87: The golden-path transcript fenced block is missing a language
specifier, so update the Markdown code fence in the production readiness audit
doc to include a tag such as bash or text. Locate the fenced block in the
transcript section and make the opening fence explicitly typed so it satisfies
MD040 and renders correctly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 0cd5a619-2295-414d-8669-4d5067b0e736
📒 Files selected for processing (7)
README.mddocs/DORIAN_USEFULNESS.mddocs/PRODUCTION_READINESS_AUDIT.mddocs/changes/production-readiness-audit.claims.jsondocs/changes/production-readiness-audit.mddocs/changes/production-readiness-audit.md.warranttests/test_readme_example.py
What & why
Two durable docs for new users / skeptical reviewers, plus a small correctness fix to the flagship README demo. No code behavior, warrant schema, checker grammar, exit-code, fold-policy, or security-posture change.
1.
fix(docs)— README quickstart claim kind (67a09eb)The "Try it in 30 seconds" demo claim — "handler() lives in app.py", backed by a C3
symbol:existence checker — was taggedkind: "behavior". That is precisely the mismatch the project's own--strength-gate=failrefuses (a load-bearingbehaviorclaim backed only by an existence check), so the headline demo violated the gate dorian now ships and promotes. Retaggedreference. Behavior-preserving under the default gate (off); the recipe still seals onverifyand revokes on drift. The black-box README test's mirrored copy is synced — its assertions check the commands, not the kind, so all tests stay green.2.
docs— audit + usefulness + dogfood (88f064d)docs/PRODUCTION_READINESS_AUDIT.md— evidence-backed readiness review: live test matrix, first-hand golden-path transcript, isolated wheel-install (zero-dep) check, full security-boundary map, verdict (MOSTLY READY — with listed risks), and a ranked punch list. Honestly flags Dependabot chore(deps): bump actions/upload-artifact from 4.6.2 to 7.0.1 #9–chore(deps): bump actions/attest-build-provenance from 1.4.4 to 4.1.0 #13 as deferred (their greencicheck does not exercise the release/publish workflows the major action bumps actually touch).docs/DORIAN_USEFULNESS.md— why dorian matters: the verification-debt problem, what it uniquely preserves, strength-labeled evidence, the trigger-vs-truth ceiling, a copy-paste user journey, and adoption fit. No invented citations.docs/changes/production-readiness-audit.mdis sealed under--strength-gate=fail(verified 7/7, 0 load-bearing high-risk), with its*.claims.jsonand the sealed*.md.warrantcommitted — matching the existingdocs/changes/convention. Load-bearing facts pinned: the two-axis implementation (binding gate = trigger, strength gate = truth) and the audit's invariants — Python>=3.11and a zero-dependency core (config-value:checkers).Evidence (this branch's base, local)
ruff check/ruff format --check: pass.off/warn/fail, atomic no-write) verified first-hand in a temp repo.Notes
--strength-gate) was merged tomain.Summary by CodeRabbit
Documentation
Tests