Conversation
ibstewart
force-pushed
the
cmake-exports
branch
from
0439a37 to
af39f69
Compare
This adds CMake rules to output the ajantv2 config such that the ajantv2 library can be built and linked against using the following: find_package(ajantv2 16.2 REQUIRED) target_link_libraries(<target> AJA::ajantv2)
ibstewart
force-pushed
the
cmake-exports
branch
from
af39f69 to
d675b86
Compare
|
This does look handy. I need to review it and make sure it doesn't break the OBS CI builds. If it doesn't break anything I will merge this soon. |
| -D__STDC_CONSTANT_MACROS) | ||
| endif() | ||
|
|
||
| add_definitions(${AJANTV2_COMPILE_DEFINITIONS}) |
There was a problem hiding this comment.
target_compile_definitions is preferred in modern cmake if you want to attach those to specific targets (and they'll be exported alongside it)
There was a problem hiding this comment.
We use target_compile_definitions for the target-specific definitions in the repo. However I need to refactor these global defines at some point across all of our targets to apply them to targets with target_compile_definitions.
|
Hi @paulh-aja . Do you have an ETA to have this potentially merged? |
|
I've given this PR a cursory look with another AJA engineer and our initial feeling is that we need to see how it fits with other NTV2 CMake changes that we're planning on landing in the repo soon. We've been doing a bit of work/rework on the ajantv2 CMake versionizing system, and the CMake install directives. I am on PTO until June 1st and the rest of the AJA engineers are currently busy on other internal tasks, so it will need to wait until early June at the soonest. |
3 participants
This adds CMake rules to output the AJANTV2
exports such that the ajantv2 library can be
built and linked against using the following: