Feature/bruno gabriel araujo lebtag - #20
Open
brlebtag wants to merge 9 commits into
Open
Conversation
…tation in free or csv format.
…to school in school_manipulation.h.
…siness rules to Challenge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Development Report:
it's been a while since I have used C++ more extensive than, saying, for small applications. I am also not aware of all C++ best practice (although I know some like RAII, even though I did not used it).
Initially I went full force in creativity but soon I realized that many ideas I tried to used (from c#) would not work here. I also got a bit scare whether I would be able to make through (because it's been a while I don't use C++). I decided to implement the solution (in c++) without worrying about anything except solving the problem.
After I sucessfully solved the problem (which I did not included into my commits). I went back to the code and tried to improve the quality of my code. I usually make strong use of names and relationships presented in the business domain in the code. But I failed to extract valuable names and relationship in this problem. I also make strong use of Interfaces, which helps to improve testability. But it is a bit weird in C++, so I was only able to use a little bit. And I also did not try to implement tests.
I personally do not use comments and in my job we use comments only when necessary. So my code is not very commented. However, I tend to implement very small functions with very self-explanatory names (and variables). I believe the best documentation is the code.
I had some problems related to undefined reference when I started using static functions, thus I had to remove the translation units. I moved all the code to header files. I did not like it but I did not find the solution to this problem. So I skipped it.