WIP: [connection] public API to retrieve peer address#122
Open
Aniketh01 wants to merge 1 commit intoaiortc:mainfrom
Open
WIP: [connection] public API to retrieve peer address#122Aniketh01 wants to merge 1 commit intoaiortc:mainfrom
Aniketh01 wants to merge 1 commit intoaiortc:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #122 +/- ##
===========================================
- Coverage 100.00% 99.97% -0.03%
===========================================
Files 24 24
Lines 4250 4252 +2
===========================================
+ Hits 4250 4251 +1
- Misses 0 1 +1
Continue to review full report at Codecov.
|
|
Why isn't this merged? What work is left? Just tests? |
Contributor
|
At first glance: tests, docstring for the new API. What's not pleasant: we are arbitrarily returning the first network address. There may be others. |
|
Maybe an API like this: connection.peer_addresses.get() # retrieves the first
connection.peer_addresses.getall() # retrieves the list
connection.peer_address == connection.peer_addresses.get() |
|
Any updates to this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.