-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Move dependency metadata to pyproject.toml #11643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a0fe9f7 to
f638514
Compare
CodSpeed Performance ReportMerging #11643 will not alter performanceComparing Summary
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11643 +/- ##
=======================================
Coverage 98.74% 98.74%
=======================================
Files 127 127
Lines 43448 43449 +1
Branches 2326 2326
=======================================
+ Hits 42903 42904 +1
Misses 389 389
Partials 156 156
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4294978 to
88664dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Backport to 3.13: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply e1aec0a on top of patchback/backports/3.13/e1aec0ac94277a8b67092293aeac3c19e17fdd86/pr-11643 Backporting merged PR #11643 into master
🤖 @patchback |
Backport to 3.14: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply e1aec0a on top of patchback/backports/3.14/e1aec0ac94277a8b67092293aeac3c19e17fdd86/pr-11643 Backporting merged PR #11643 into master
🤖 @patchback |
|
@cdce8p could you send those backports in? |
Looking at it now. |
|
@webknjaz If you've some spare time while I do the backports, this one is has also been waiting for your review for some time now aio-libs/frozenlist#644. |
PR aio-libs#11643. This is a follow-up to aio-libs#9951 implementing PEP 621. (cherry picked from commit e1aec0a)
PR aio-libs#11643. This is a follow-up to aio-libs#9951 implementing PEP 621. (cherry picked from commit e1aec0a)
What do these changes do?
Followup to #9951. Move dependencies and optional dependencies from
setup.cfgtopyproject.toml.Are there changes in behavior for the user?
Is it a substantial burden for the maintainers to support this?
Related issue number
Checklist
CONTRIBUTORS.txtCHANGES/foldername it
<issue_or_pr_num>.<type>.rst(e.g.588.bugfix.rst)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature: A new behavior, public APIs. That sort of stuff..deprecation: A declaration of future API removals and breakingchanges in behavior.
.breaking: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc: Notable updates to the documentation structure or buildprocess.
.packaging: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.