- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 2.2k
 
Allow caching of middleware construction #10890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
| 
           @bdraco Does the proxy code have any impact on middlewares? Seems to be a ClientRequest created here with a lot less arguments, just wondering if there's any issue here: Line 1364 in 180b5ab 
 Otherwise, I guess that's why all those parameters have defaults currently, in which case we'll need to do the same for these 2 as well.  | 
    
          Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@           Coverage Diff           @@
##           master   #10890   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         127      127           
  Lines       43558    43587   +29     
  Branches     2320     2320           
=======================================
+ Hits        43008    43037   +29     
  Misses        390      390           
  Partials      160      160           
 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry.  | 
    
          
 Feels to me like there should be a separate ClientProxyRequest or something. I think if we separated them, it'd remove a bunch of asserts and make static typing a lot cleaner.  | 
    
          
CodSpeed Performance ReportMerging #10890 will not alter performanceComparing  Summary
  | 
    
No description provided.