⬆️ Loosen aiida-core pin#775
Conversation
There was a problem hiding this comment.
Any reason it should be at least 2.7.1? Do we depend on anything from there?
There was a problem hiding this comment.
doesn't matter anymore, we anyway yanked all 2.7.x below 2.7.3...
GeigerJ2
force-pushed
the
deps/loosen-aiida-core-pin
branch
from
f17296e to
7176c07
Compare
| "myst-nb~=1.0.0", | ||
| "nbsphinx", | ||
| "furo", | ||
| "aiida-core~=2.7.1", |
There was a problem hiding this comment.
Not introduced here, but: if it's already a core dependency, why is it also an optional one?
There was a problem hiding this comment.
as we say in german: "doppelt haelt besser" :D
jkjk, will remove. Good catch!
mbercx
left a comment
mbercx
left a comment
There was a problem hiding this comment.
LGTM! 🚀
I can't immediately think of anything in aiida-core v2.8 that could break workgraph, but I don't really know the codebase. If the tests pass, we should be ok. If then something is still broken, it's an opportunity to improve our tests. Win-Win! :D
OK, tests have also passed with |
|
@GeigerJ2 could we make a new release? I'm working on a workgraph related project that requires aiida-core 2.8.0 due to the support of newer numpy versions. |
3 participants
Closes #774