Add proper authentication#123
Draft
edan-bainglass wants to merge 43 commits into
Draft
Conversation
A single endpoint handling both model types complicates matters for FastAPI w.r.t the docs due to the nature of the composite discriminator. Splitting the endpoints resolves this issue and is in line with the unique intentions of the two creation paths.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #123 +/- ##
==========================================
- Coverage 93.39% 88.18% -5.22%
==========================================
Files 28 48 +20
Lines 999 2039 +1040
==========================================
+ Hits 933 1798 +865
- Misses 66 241 +175
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #122
Current implementation is mostly by an agent, as I am unfamiliar with FastAPI authentication.
Need to check this one carefully against standards!
Update
The implementation doesn't quite work.