Skip to content

feat(core): enter & leave traverse handlers - #21

Open
Asuka109 wants to merge 7 commits into
aidenybai:mainfrom
Asuka109:feat/traverser-leave-handler
Open

feat(core): enter & leave traverse handlers#21
Asuka109 wants to merge 7 commits into
aidenybai:mainfrom
Asuka109:feat/traverser-leave-handler

Conversation

@Asuka109

Copy link
Copy Markdown
Contributor

#18

@aidenybai I have refactored the traverseFiber into stack-based implementation and can accept an object syntax with enter & leave handlers. But it can also accept the previous selector handler as an enter handler.

I changed the jsx option from react to react-jsx for resolving some biome warnings. But it might be bring some compatiable issues to applications with legacy jsx runtime react version. Not sure is it acceptable.

This pull request includes several changes to the testing setup and the traverseFiber function. The most important changes involve adding new tests for traverseFiber, enhancing the traverseFiber function, and updating the test configuration.

Enhancements to traverseFiber function:

  • src/core.ts: Introduced FiberSelector type and TraverseFiberOptions interface to improve the flexibility of the traverseFiber function. The function now supports both entry and leave handlers and can traverse the fiber tree in ascending order.

New tests for traverseFiber:

  • src/core.test.tsx: Added comprehensive tests for the traverseFiber function, including tests for traversing in both directions, handling entry and leave events, and verifying stack behavior.

Updates to testing setup:

  • setup-test.ts: Added an import for ./src/rdt-hook to the test setup file.
  • vitest.config.ts: Updated the test configuration to include setupFiles pointing to ./setup-test.ts.

@vercel

vercel Bot commented Jan 19, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bippy ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2025 2:46pm

@pkg-pr-new

pkg-pr-new Bot commented Jan 19, 2025

Copy link
Copy Markdown

Open in Stackblitz

npm i https://pkg.pr.new/bippy@21

commit: 1044194

@Asuka109
Asuka109 force-pushed the feat/traverser-leave-handler branch from ab3bcb5 to 1044194 Compare January 22, 2025 16:22
@changeset-bot

changeset-bot Bot commented Jan 22, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 414be0a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant