Stubs fallback #1011
Merged
Stubs fallback #1011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Milesi <[email protected]>
Signed-off-by: Alexandre Milesi <[email protected]>
Signed-off-by: Alexandre Milesi <[email protected]>
Signed-off-by: Alexandre Milesi <[email protected]>
Signed-off-by: Alexandre Milesi <[email protected]>
milesial
requested review from
a team,
gleon99,
mkhazraee and
roiedanino
as code owners
Contributor
|
@ayushag-nv can you help drive this PR and get it merged? |
Contributor
|
@roiedanino clang format fixed |
roiedanino
requested changes
Nov 20, 2025
Contributor
roiedanino
left a comment
roiedanino
left a comment
There was a problem hiding this comment.
There are many formatting of code unrelated to this PR.
Please revert those and use git-clang-format to format just your PR diff
Contributor
|
/build |
Signed-off-by: Alexandre Milesi <[email protected]>
Signed-off-by: Alexandre Milesi <[email protected]>
Contributor
Author
|
@roiedanino I cleaned up some formatting and added a test so that we avoid divergence of stubs vs real APIs in the future, can you take another look? |
roiedanino
reviewed
Dec 3, 2025
Contributor
|
/build |
Signed-off-by: Alexandre Milesi <[email protected]>
Signed-off-by: milesial <[email protected]>
Contributor
|
/build |
roiedanino
previously approved these changes
Dec 4, 2025
Contributor
Author
|
@roiedanino I don't see AWS tests finishing, can we resolve CI issues and merge this one? |
Contributor
|
/ok to test 0e6d2cf |
Contributor
|
/build |
roiedanino
approved these changes
Dec 10, 2025
Contributor
|
/build |
brminich
approved these changes
Dec 10, 2025
Contributor
|
/build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow building with stubs as a fallback when NIXL is not found.
Also adds some missing stub APIs.
NIXL_NO_STUBS_FALLBACK=1 to disable