RUST/TEST: test sync_manager #1006
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi evgeny-leksikov! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
Contributor
Author
|
/build |
gleon99
previously approved these changes
Nov 20, 2025
roiedanino
previously approved these changes
Nov 20, 2025
evgeny-leksikov
dismissed stale reviews from roiedanino and gleon99
via
efa1b17
evgeny-leksikov
force-pushed
the
rust_test_sync_manager
branch
from
910f40c to
efa1b17
Compare
Contributor
Author
|
temporary rebased on top of #829 |
Signed-off-by: Evgeny Leksikov <[email protected]>
evgeny-leksikov
force-pushed
the
rust_test_sync_manager
branch
from
cb1deb2 to
5d9544c
Compare
Contributor
Author
|
/build |
roiedanino
reviewed
Dec 10, 2025
Comment on lines
+43
to
+54
| let data_calls = Rc::new(Cell::new(0)); | ||
| let backend_calls = Rc::new(Cell::new(0)); | ||
|
|
||
| let data = DummyData { | ||
| value: Cell::new(0), | ||
| data_calls: data_calls.clone(), | ||
| should_fail: Cell::new(false), | ||
| }; | ||
| let backend = DummyBackend { | ||
| sync_calls: backend_calls.clone(), | ||
| }; | ||
| let mgr = SyncManager::new(data, backend); |
Contributor
There was a problem hiding this comment.
Let's try to reduce code duplication in the initialization of those tests, maybe we can use some kind of default constructors that will populate those fields:
let data = DummyData::default();
let backend = DummyBackend::default();
// and so on
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add new tests for SyncManager implementation.
Why?
#828 (comment)
NOTE: marked as a draft since the PR #1003 improves sync_manager, so this PR will require to resolve conflicts.