scale-color $lightness must use $secondary for dark themes #7
Conversation
|
cursor review |
🚨 Bugbot couldn't runSomething went wrong. Try again by commenting "Cursor review" or "bugbot run", or contact support (requestId: serverGenReqId_920c83f9-bdab-42c8-9a2d-f8c809060d5e). |
|
cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bugbot free trial expires on August 11, 2025
Learn more in the Cursor dashboard.
| display: inline-block; | ||
| margin-top: 5px; | ||
| color: scale-color($primary, $lightness: 30%); | ||
| color: dark-light-choose(scale-color($primary, $lightness: 50%), scale-color($secondary, $lightness: 50%)); |
There was a problem hiding this comment.
Bug: CSS Lightness Override in Theme Conversion
During the conversion to dark-light-choose, several CSS properties incorrectly set the primary color's lightness to 50% for light themes. This overrides the original lightness values (e.g., 20%, 30%) that should have been preserved. This unintended change alters the appearance of elements in light themes. The dark-light-choose function should retain the original lightness for the light theme and provide an appropriate contrasting lightness for the dark theme.
Locations (3)
| .custom-message-length { | ||
| margin: -10px 0 10px 20px; | ||
| color: scale-color($primary, $lightness: 70%); | ||
| color: dark-light-choose(scale-color($primary, $lightness: 30%), scale-color($secondary, $lightness: 70%)); |
There was a problem hiding this comment.
Bug: Light Theme Color Shift Issue
The color property for .custom-message-length was incorrectly updated. The dark-light-choose function now sets the light theme color to scale-color($primary, $lightness: 30%), changing it from the original 70% lightness and making it significantly darker than intended in light themes.
Locations (1)
| a { | ||
| font-weight: bold; | ||
| color: scale-color($primary, $lightness: 30%); | ||
| color: dark-light-choose(scale-color($primary, $lightness: 70%), scale-color($secondary, $lightness: 30%)); |
There was a problem hiding this comment.
Bug: Light Theme Color Lightness Incorrect
The dark-light-choose function incorrectly sets the light theme color's lightness to 70% instead of preserving its original 30%. This alters the existing light theme appearance. The correct implementation should use 30% lightness for the light theme and 70% for the dark theme.
Locations (2)
3 participants
Test 7