Minor adjustments #54
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems RbConfig was introduced somewhere around Ruby 2.0. So now that Ruby 3.1 is around its predecessor Config should be ready to be dropped.
This should be obsolete since Ruby 2.0 which got released in 2013 and has been obsoleted in 2016.
markuspg
force-pushed
the
minor_adjustments
branch
from
6136264 to
51678a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I badly need Ruby 3 support for this gem. So I started poking my nose around it to make myself accustomed with it. As a first step I started by fixing trivial RuboCop offenses around the Rakefile which are upsetting my IDE ;-) Additionally I added descriptions to the tasks. The most relevant fix should be the replacement of the deprecated
ConfigbyRbConfig.