fix: handle empty request timing lists and complete compute_metrics in get_numbers_sequential (closes #542)#547
Open
botbikamordehai2-sketch wants to merge 1 commit into
Conversation
…n get_numbers_sequential (closes agiresearch#542)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
get_numbers_sequential()function inaios/utils/calculator.pyhad two bugs:request_waiting_times[0]andrequest_turnaround_times[0]without checking if the lists were empty, causing anIndexError.compute_metricshelper function at the end ofget_numbers_sequentialwas incomplete/truncated, and the function had no return statement.Fix
if request_waiting_times:andif request_turnaround_times:) before accessing index 0 of the timing lists.compute_metricsfunction body and added thereturn metricsstatement, mirroring the pattern already used inget_numbers_concurrent.Closes #542