fix: map SP1VerificationError::Other to ProofVerificationError::Other #327
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fibonacci747
requested review from
Ekleog-Polygon,
Freyskeyd,
adria0pol,
atanmarko,
hadjiszs,
iljakuklic and
polykeith
|
|
atanmarko
approved these changes
Dec 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SP1VerificationError::Otheris documented as a generic “proof is invalid” error, not a core machine verification failure. Previously mapped it intoProofVerificationError::Core, which misclassified these errors and left the Other variant unused. This change mapsSP1VerificationError::OthertoProofVerificationError::Otherso logs and any downstream handling see the correct error category.