fix(harness): stream Docker sandbox file transfers - #2530
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
ac62daa to
dde64d6
Compare
|
CI note: the new DockerSandboxFileTransferTest passed on both Ubuntu and Windows. In run 30750987683, Ubuntu failed in the unrelated HarnessAgentSubagentStreamEventsTest; an isolated local rerun of that class passed all 4 tests, and Windows was canceled by fail-fast. In run 30751331762, Windows failed in the unrelated AgentSpawnToolPlanModeTest because JUnit could not delete its temporary directory; Ubuntu was then canceled by fail-fast. The new transfer test does not create files or processes, and the affected tests/files are outside this change. I do not have repository permission to rerun Actions. Could a maintainer please rerun the failed checks? |
|
Thanks for rerunning the checks. The Windows build now passes. The Ubuntu job was canceled mid-build without a test failure. Could you please rerun the Ubuntu check when convenient? |
AgentScope-Java Version
2.0.1-SNAPSHOT
Description
Fixes #1560.
SandboxBackedFilesystem.uploadFilespreviously fell back to a shell command that embedded the complete Base64 payload in thedocker execcommand line. Large files therefore exceeded the host command-line limit on Windows (CreateProcess error=206) and could also hitE2BIGon Unix-like hosts.This PR:
DockerSandboximplement the existingSandboxFileTransfercapability;docker exec -istandard input instead of command-line arguments;Validation performed locally:
mvn -pl agentscope-harness -am spotless:applymvn -pl agentscope-harness -am -DskipTests compilemvn -pl agentscope-harness -am "-Dtest=SandboxBackedFilesystemTest,DockerSandboxFileTransferTest" test(8 tests passed)The full
mvn testsuite did not complete within the local validation window, so the full-suite checkbox is intentionally left open for CI.Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test); the focused harness tests above pass and CI will run the complete suite