You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
make test-06-multi-worker create Bob via hiclaw apply worker instead of a Manager DM request
keep the rest of the test focused on multi-worker collaboration after Alice and Bob exist
avoid CI flakes where the Manager is still processing heartbeat/task follow-ups or hits tool-guard approval before creating Bob
Why
Recent failures on #972, #983, #984, and older PRs all failed in test-06-multi-worker with the same pattern: the Manager did not produce a matching Bob creation reply, wait_worker_provisioned bob timed out, hiclaw get workers bob returned 404, and hiclaw-worker-bob did not exist. The logs also show the Manager processing unrelated heartbeat/task work or denied shell commands during the Bob creation window.
This makes Bob creation an unreliable LLM interaction inside a test whose stated purpose is multi-worker collaboration. test-02-create-worker already covers Manager-mediated worker creation for Alice; test-06 can use deterministic setup for Bob.
Verification
bash -n tests/test-06-multi-worker.sh
git diff --check
I could not run the embedded integration test locally because this environment cannot access /var/run/docker.sock (permission denied).
@shiyiyue1102 Hi! This PR makes the multi-worker test-06-multi-worker.sh bob setup deterministic by replacing the LLM-driven DM instruction with a direct hiclaw apply worker --name bob ... call. This bypasses the SHARD_A flake that has been blocking PRs #972, #973, #975, #976, #983, #984 (all hit "Manager never invoked hiclaw create worker --name bob" — confirmed by inspecting #984's downloaded artifacts where the hiclaw-worker-bob session directory did not exist at all).
Just rebased onto current main and CI is 18/18 green (verified just now). If you can land this first, the next CI runs on the six Tier-3 PRs above should turn green automatically — they all hit the same root cause this PR fixes. Branch is MERGEABLE. Could you prioritize this one?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test-06-multi-workercreate Bob viahiclaw apply workerinstead of a Manager DM requestWhy
Recent failures on #972, #983, #984, and older PRs all failed in
test-06-multi-workerwith the same pattern: the Manager did not produce a matching Bob creation reply,wait_worker_provisioned bobtimed out,hiclaw get workers bobreturned 404, andhiclaw-worker-bobdid not exist. The logs also show the Manager processing unrelated heartbeat/task work or denied shell commands during the Bob creation window.This makes Bob creation an unreliable LLM interaction inside a test whose stated purpose is multi-worker collaboration.
test-02-create-workeralready covers Manager-mediated worker creation for Alice;test-06can use deterministic setup for Bob.Verification
bash -n tests/test-06-multi-worker.shgit diff --checkI could not run the embedded integration test locally because this environment cannot access
/var/run/docker.sock(permission denied).