Skip to content

Rich failure logging#36

Merged
JornC merged 6 commits intoaerius:mainfrom
JornC:rich-failure-logging
Apr 14, 2026
Merged

Rich failure logging#36
JornC merged 6 commits intoaerius:mainfrom
JornC:rich-failure-logging

Conversation

@JornC
Copy link
Copy Markdown
Member

@JornC JornC commented Apr 2, 2026

This adds failure diagnostics backward compatibly: when failures occur, it dumps network diagnostics to LOG, including URL, error text, status code, and response body.

Re: the test, it's basically fake and meant to be run manually, won't ever work in a CI environment and thus will always succeed

@JornC JornC force-pushed the rich-failure-logging branch 2 times, most recently from c8dc5ee to 46fc568 Compare April 2, 2026 14:38
@JornC JornC force-pushed the rich-failure-logging branch from 46fc568 to a50a999 Compare April 2, 2026 14:39
Comment thread src/main/java/nl/aerius/print/QuittableChrome.java Outdated
…es()

Disabled by default to avoid unnecessary CDP overhead. When off, network
events are not subscribed to and no tracker is allocated.
@JornC JornC requested a review from BertScholten April 3, 2026 07:54
Comment thread src/test/java/nl/aerius/print/NetworkFailureTrackingTest.java Outdated
Comment thread src/test/java/nl/aerius/print/NetworkFailureTrackingTest.java
@JornC JornC requested a review from BertScholten April 9, 2026 10:57
Copy link
Copy Markdown
Member

@BertScholten BertScholten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JornC JornC merged commit d96bfc5 into aerius:main Apr 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants