Improvements to metrics reporting#120
Open
Hilbrand wants to merge 1 commit intoaerius:mainfrom
Open
Conversation
Member
Hilbrand
commented
Apr 17, 2026
Hilbrand
commented
- Striped first part of queue name attribute; only last part is relevant as rest is redundant (also makes viewing in graphana cleaner as only last part will be shown).
- Description of metrics that are registered multiple times with different attributes should be the same for each registration otherwise Otel will report warning.
- Added missing descriptions to some of the metrics.
- Striped first part of queue name attribute; only last part is relevant as rest is redundant (also makes viewing in graphana cleaner as only last part will be shown). - Description of metrics that are registered multiple times with different attributes should be the same for each registration otherwise Otel will report warning. - Added missing descriptions to some of the metrics.
fmadjdian
reviewed
May 7, 2026
Contributor
fmadjdian
left a comment
fmadjdian
left a comment
There was a problem hiding this comment.
LGTM. We need to check if the changing things like ("aer.worker.OPS", "aerius.worker.calculator") impacts the metrics used for autoscaling. From what i can see it does not, but needs a second pair of eyes maybe. See: https://github.com/aerius/calculator/blob/main/terraform/application_services/ecs_services/service_configuration/autoscaling_workers.tf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.