AER-3162 - Group XSD validation errors by source location#381
Merged
JornC merged 7 commits intoaerius:mainfrom May 7, 2026
Merged
AER-3162 - Group XSD validation errors by source location#381JornC merged 7 commits intoaerius:mainfrom
JornC merged 7 commits intoaerius:mainfrom
Conversation
Validation events from JAXB unmarshalling are now grouped by their (line, column) locator so a single bad value no longer produces multiple separate errors. Within each group only the highest-severity events are kept and their messages combined. Each combined message is prefixed with [line N, col M] so users can locate the offending value in larger GML files.
Drop the within-group severity filter so all events at a location are joined into the combined message. Lower-severity events (e.g. JAXB's bare NumberFormatException 'None') were technically redundant but the no-loss guarantee is more valuable than the cosmetic gain from dropping them.
Restore the within-group severity filter from the first iteration but extract it into a named, javadoc'd helper (discardRedundantLowerSeverityEvents) that states it is a deliberate lossy step and documents exactly which events get dropped: JAXB's bare ERROR-severity wrapping of a primitive parse failure (e.g. just "None") at the same location as the FATAL_ERROR cvc-* events that already convey the same information with full context.
Hilbrand
reviewed
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation events from JAXB are now grouped by their (line, column) locator so a single bad value no longer produces multiple separate errors.
Within each group only the highest-severity events are kept and their messages combined. Each combined message is prefixed with [line N, col M] so users can locate the offending value in larger GML files.