-
Notifications
You must be signed in to change notification settings - Fork 235
[MNT] Soft-DTW refactor #3124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[MNT] Soft-DTW refactor #3124
Conversation
Thank you for contributing to
|
| # Skip for now | ||
| if dist["name"] in MIN_DISTANCES or dist["name"] in MP_DISTANCES: | ||
| if ( | ||
| dist["name"] in MIN_DISTANCES |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a note because Soft-DTW can return negative values it won't work with any sklearn model. Therefore, I am skipping the tests in the file when using soft-dtw
| if ( | ||
| dist["name"] in MIN_DISTANCES | ||
| or dist["name"] in MP_DISTANCES | ||
| or dist["name"] in ["soft_dtw"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Soft-DTW can be negative so just skipping this test for it
Reference Issues/PRs
This PR relies on #3122
What does this implement/fix? Explain your changes.
This PR moves Soft-DTW to a new submodule of elastic distance "soft". This module will contain Soft-DTW and the coming soon other soft distances.
Specifically the changes are:
Does your contribution introduce a new dependency? If yes, which one?
Any other comments?
PR checklist
For all contributions
For new estimators and functions
__maintainer__at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access